Blame view

node_modules/eslint/lib/rules/prefer-spread.js 3.35 KB
ce4c83ff   wxy   初始提交
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
  /**
   * @fileoverview A rule to suggest using of the spread operator instead of `.apply()`.
   * @author Toru Nagashima
   */
  
  "use strict";
  
  const astUtils = require("../ast-utils");
  
  //------------------------------------------------------------------------------
  // Helpers
  //------------------------------------------------------------------------------
  
  /**
   * Checks whether or not a node is a `.apply()` for variadic.
   * @param {ASTNode} node - A CallExpression node to check.
   * @returns {boolean} Whether or not the node is a `.apply()` for variadic.
   */
  function isVariadicApplyCalling(node) {
      return (
          node.callee.type === "MemberExpression" &&
          node.callee.property.type === "Identifier" &&
          node.callee.property.name === "apply" &&
          node.callee.computed === false &&
          node.arguments.length === 2 &&
          node.arguments[1].type !== "ArrayExpression" &&
          node.arguments[1].type !== "SpreadElement"
      );
  }
  
  
  /**
   * Checks whether or not `thisArg` is not changed by `.apply()`.
   * @param {ASTNode|null} expectedThis - The node that is the owner of the applied function.
   * @param {ASTNode} thisArg - The node that is given to the first argument of the `.apply()`.
   * @param {RuleContext} context - The ESLint rule context object.
   * @returns {boolean} Whether or not `thisArg` is not changed by `.apply()`.
   */
  function isValidThisArg(expectedThis, thisArg, context) {
      if (!expectedThis) {
          return astUtils.isNullOrUndefined(thisArg);
      }
      return astUtils.equalTokens(expectedThis, thisArg, context);
  }
  
  //------------------------------------------------------------------------------
  // Rule Definition
  //------------------------------------------------------------------------------
  
  module.exports = {
      meta: {
          docs: {
              description: "require spread operators instead of `.apply()`",
              category: "ECMAScript 6",
              recommended: false,
              url: "https://eslint.org/docs/rules/prefer-spread"
          },
  
          schema: [],
  
          fixable: "code"
      },
  
      create(context) {
          const sourceCode = context.getSourceCode();
  
          return {
              CallExpression(node) {
                  if (!isVariadicApplyCalling(node)) {
                      return;
                  }
  
                  const applied = node.callee.object;
                  const expectedThis = (applied.type === "MemberExpression") ? applied.object : null;
                  const thisArg = node.arguments[0];
  
                  if (isValidThisArg(expectedThis, thisArg, sourceCode)) {
                      context.report({
                          node,
                          message: "Use the spread operator instead of '.apply()'.",
                          fix(fixer) {
                              if (expectedThis && expectedThis.type !== "Identifier") {
  
                                  // Don't fix cases where the `this` value could be a computed expression.
                                  return null;
                              }
  
                              const propertyDot = sourceCode.getFirstTokenBetween(applied, node.callee.property, token => token.value === ".");
  
                              return fixer.replaceTextRange([propertyDot.range[0], node.range[1]], `(...${sourceCode.getText(node.arguments[1])})`);
                          }
                      });
                  }
              }
          };
      }
  };