Blame view

node_modules/eslint/lib/rules/no-useless-call.js 2.74 KB
ce4c83ff   wxy   初始提交
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
  /**
   * @fileoverview A rule to disallow unnecessary `.call()` and `.apply()`.
   * @author Toru Nagashima
   */
  
  "use strict";
  
  const astUtils = require("../ast-utils");
  
  //------------------------------------------------------------------------------
  // Helpers
  //------------------------------------------------------------------------------
  
  /**
   * Checks whether or not a node is a `.call()`/`.apply()`.
   * @param {ASTNode} node - A CallExpression node to check.
   * @returns {boolean} Whether or not the node is a `.call()`/`.apply()`.
   */
  function isCallOrNonVariadicApply(node) {
      return (
          node.callee.type === "MemberExpression" &&
          node.callee.property.type === "Identifier" &&
          node.callee.computed === false &&
          (
              (node.callee.property.name === "call" && node.arguments.length >= 1) ||
              (node.callee.property.name === "apply" && node.arguments.length === 2 && node.arguments[1].type === "ArrayExpression")
          )
      );
  }
  
  
  /**
   * Checks whether or not `thisArg` is not changed by `.call()`/`.apply()`.
   * @param {ASTNode|null} expectedThis - The node that is the owner of the applied function.
   * @param {ASTNode} thisArg - The node that is given to the first argument of the `.call()`/`.apply()`.
   * @param {SourceCode} sourceCode - The ESLint source code object.
   * @returns {boolean} Whether or not `thisArg` is not changed by `.call()`/`.apply()`.
   */
  function isValidThisArg(expectedThis, thisArg, sourceCode) {
      if (!expectedThis) {
          return astUtils.isNullOrUndefined(thisArg);
      }
      return astUtils.equalTokens(expectedThis, thisArg, sourceCode);
  }
  
  //------------------------------------------------------------------------------
  // Rule Definition
  //------------------------------------------------------------------------------
  
  module.exports = {
      meta: {
          docs: {
              description: "disallow unnecessary calls to `.call()` and `.apply()`",
              category: "Best Practices",
              recommended: false,
              url: "https://eslint.org/docs/rules/no-useless-call"
          },
  
          schema: []
      },
  
      create(context) {
          const sourceCode = context.getSourceCode();
  
          return {
              CallExpression(node) {
                  if (!isCallOrNonVariadicApply(node)) {
                      return;
                  }
  
                  const applied = node.callee.object;
                  const expectedThis = (applied.type === "MemberExpression") ? applied.object : null;
                  const thisArg = node.arguments[0];
  
                  if (isValidThisArg(expectedThis, thisArg, sourceCode)) {
                      context.report({ node, message: "unnecessary '.{{name}}()'.", data: { name: node.callee.property.name } });
                  }
              }
          };
      }
  };